- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
doc: add release key for Danielle Adams #35545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
            danielleadams
  wants to merge
  1
  commit into
  nodejs:master
from
danielleadams:add-danielleadams-gpg-key
  
      
      
   
      
    
                
     Closed
            
            doc: add release key for Danielle Adams #35545
                    danielleadams
  wants to merge
  1
  commit into
  nodejs:master
from
danielleadams:add-danielleadams-gpg-key
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Add Danielle Adams's release key.
              
                    richardlau
  
              
              approved these changes
              
                  
                    Oct 7, 2020 
                  
              
              
            
            
              
                    BethGriggs
  
              
              approved these changes
              
                  
                    Oct 7, 2020 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can import the key too
              
                    codebytere
  
              
              approved these changes
              
                  
                    Oct 7, 2020 
                  
              
              
            
            
              
                    MylesBorins
  
              
              approved these changes
              
                  
                    Oct 8, 2020 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
              
                    Trott
  
              
              approved these changes
              
                  
                    Oct 8, 2020 
                  
              
              
            
            
              
                    lpinca
  
              
              approved these changes
              
                  
                    Oct 19, 2020 
                  
              
              
            
            
| Commit Queue failed- Loading data for nodejs/node/pull/35545 ✔ Done loading data for nodejs/node/pull/35545 ----------------------------------- PR info ------------------------------------ Title doc: add release key for Danielle Adams (#35545) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch danielleadams:add-danielleadams-gpg-key -> nodejs:master Labels doc, notable-change Commits 1 - doc: add release key for Danielle Adams Committers 1 - Danielle Adams PR-URL: https://github.com/nodejs/node/pull/35545 Reviewed-By: Richard Lau Reviewed-By: Beth Griggs Reviewed-By: Shelley Vohr Reviewed-By: Myles Borins Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35545 Reviewed-By: Richard Lau Reviewed-By: Beth Griggs Reviewed-By: Shelley Vohr Reviewed-By: Myles Borins Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ✖ Last GitHub CI failed ℹ Doc-only changes ℹ This PR was created on Wed, 07 Oct 2020 18:05:22 GMT ✔ Approvals: 6 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35545#pullrequestreview-504142713 ✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504166059 ✔ - Shelley Vohr (@codebytere) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504259102 ✔ - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504384484 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504708969 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35545#pullrequestreview-512089607 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/317344068 | 
| Landed in 6b6bbfe | 
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Oct 20, 2020 
    
    
      
  
    
      
    
  
Add Danielle Adams's release key. PR-URL: #35545 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
    
  BethGriggs 
      pushed a commit
      that referenced
      this pull request
    
      Oct 21, 2020 
    
    
      
  
    
      
    
  
Add Danielle Adams's release key. PR-URL: #35545 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
      
     Merged
  
    
  BethGriggs 
      added a commit
      that referenced
      this pull request
    
      Oct 21, 2020 
    
    
  
  This was referenced Sep 29, 2022 
      
  This was referenced Oct 5, 2022 
      
  This was referenced Oct 8, 2022 
      
  This was referenced Oct 26, 2022 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    doc
  Issues and PRs related to the documentations. 
  
    notable-change
  PRs with changes that should be highlighted in changelogs. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Add Danielle Adams's release key.
Checklist